Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix inference for some parsers, add type testing #75

Merged
merged 8 commits into from
Feb 21, 2023
Merged

fix(types): fix inference for some parsers, add type testing #75

merged 8 commits into from
Feb 21, 2023

Conversation

TheFedaikin
Copy link
Collaborator

Closes #48

@TheFedaikin TheFedaikin self-assigned this Jan 22, 2023
@vercel
Copy link

vercel bot commented Jan 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sigma ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Feb 21, 2023 at 9:32AM (UTC)

@TheFedaikin TheFedaikin added A-types Area: Issues related to types and type inference A-tests Area: Issues related to tests and coverage P-medium Priority: Medium labels Jan 22, 2023
@coveralls
Copy link

coveralls commented Jan 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4231192138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3953132725: 0.0%
Covered Lines: 265
Relevant Lines: 265
💛 - Coveralls

TheFedaikin
TheFedaikin commented Jan 22, 2023
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@norskeld
test(types): use typeof with expectTypeOf for proper checks
48621e6 
Otherwise TS is not happy, which is understandable.
norskeld
norskeld approved these changes Feb 21, 2023
View reviewed changes
Copy link
Owner

@norskeld norskeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work, thanks mate.

src/__tests__/types.spec-d.ts Show resolved Hide resolved
@norskeld norskeld marked this pull request as ready for review February 21, 2023 10:45
@norskeld
Copy link
Owner

norskeld commented Feb 21, 2023 •
edited
Loading

Although I would change the type of this change since it actually provides some fixes to types and inference. Probably fix(types) would do.

@TheFedaikin TheFedaikin changed the title test(types): add type tests fix(types): fix inference and add type testing Feb 21, 2023
@TheFedaikin TheFedaikin changed the title fix(types): fix inference and add type testing fix(types): add type testing, fix inference for some parsers Feb 21, 2023
@TheFedaikin TheFedaikin changed the title fix(types): add type testing, fix inference for some parsers fix(types): fix inference for some parsers, add type testing Feb 21, 2023
@TheFedaikin TheFedaikin merged commit 80cccf0 into master Feb 21, 2023
@TheFedaikin TheFedaikin deleted the test/types branch February 21, 2023 11:08
norskeld pushed a commit that referenced this pull request Feb 21, 2023
@semantic-release-bot
chore(release): release 3.6.1 [skip ci]
bafa35e 
## [3.6.1](v3.6.0...v3.6.1) (2023-02-21)

### Bug Fixes

* **types:** fix inference for some parsers, add type testing ([#75](#75)) ([80cccf0](80cccf0)), closes [#48](#48)
@norskeld
Copy link
Owner

This PR is included in version 3.6.1.

@norskeld norskeld added the R-released Semantic Release: Success label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norskeld norskeld norskeld approved these changes

Assignees

@TheFedaikin TheFedaikin

Labels
A-tests Area: Issues related to tests and coverage A-types Area: Issues related to types and type inference P-medium Priority: Medium R-released Semantic Release: Success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: test types with expect-type
3 participants
@TheFedaikin @coveralls @norskeld