feat: hybrid bundles - esm + cjs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1460564001
💛 - Coveralls |
norskeld
pushed a commit
that referenced
this pull request
Nov 15, 2021
# [1.1.0](v1.0.0...v1.1.0) (2021-11-15) ### Features * hybrid bundles - esm + cjs ([#10](#10)) ([5987ad7](5987ad7))
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
# [1.1.0](v1.0.0...v1.1.0) (2021-11-15) ### Features * hybrid bundles - esm + cjs ([#10](#10)) ([5987ad7](5987ad7))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR:
@nrsk/sigmapackage is amodulenow.This actually opens a darn Pandora's box, because tooling isn't really ready, mainly due to the experimental status of the ESM loaders, but whatever, tsm worked decently here.
Why unminified? Because nowadays we either use bundlers in userland, so everything used/imported will be tree-shaked and optimized anyway, or don't use them at all, e.g. we are on node with CJS, which doesn't really make use of tree-shaking and minification.
d.ts.exportsfield in thepackage.json.index.ts. This is actually related, so had to do that here.Resolves #4