-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - fixing several broken hyperlinks #904
Comments
Been a few days so I thought I'd ping this thread. Thank you! |
Hi, sorry about that. Thanks for identifying the broken links, the tricky bit here is that the paths should be generated by sphinx rather than be hardcoded (otherwise links might point to the wrong thing in some cases). I dropped a comment in the PR you opened with an example. |
All good. Hopefully these relative paths are correct. As long as the processors PR goes well then I'll work up changes for the list below.
nornir/docs/tutorial/failed_tasks.ipynb Line 381 in 95ef20f
nornir/docs/tutorial/failed_tasks.ipynb Line 408 in 95ef20f
nornir/docs/howto/handling_connections.ipynb Line 122 in 95ef20f
|
I think this one can be close, can't it? Feel free to reopen otherwise. |
🎯 Once I figure out how to get sphinx working so I can perform a local test then I'll know for sure.
InitNornir docs link doesn't 404, so it is fixed at the current date+time.
Correction:
Correction:
Correction:
Correction: |
Hello. It's nice to virtually meet you. 😀
I saw the notes on issue #593 and figured I can pitch in to fix some links up!
I believe I've accurately identified the corresponding readthedocs URL, but another set of eyes (please) couldn't hurt. Thank you!
I'd be glad to submit PRs for these docs fixes (once there's some feedback).
Would the maintainers prefer a PR per documentation file?
nornir/docs/tutorial/processors.ipynb
Line 9 in 95ef20f
discussed on issue #593
nornir/docs/tutorial/initializing_nornir.ipynb
Line 146 in 95ef20f
intent is probably linking to https://nornir.readthedocs.io/en/latest/api/nornir/init_nornir.html#nornir.init_nornir.InitNornir
nornir/docs/tutorial/failed_tasks.ipynb
Line 381 in 95ef20f
intent seems to be https://nornir.readthedocs.io/en/latest/api/nornir/core/state.html#nornir.core.state.GlobalState
nornir/docs/tutorial/failed_tasks.ipynb
Line 408 in 95ef20f
https://nornir.readthedocs.io/en/latest/api/nornir/core/state.html#nornir.core.state.GlobalState.recover_host
and
https://nornir.readthedocs.io/en/latest/api/nornir/core/state.html#nornir.core.state.GlobalState.reset_failed_hosts
nornir/docs/howto/handling_connections.ipynb
Line 67 in 95ef20f
https://nornir.readthedocs.io/en/latest/api/nornir/core/inventory.html#nornir.core.inventory.Host.open_connection
and
https://nornir.readthedocs.io/en/latest/api/nornir/core/inventory.html#nornir.core.inventory.Host.close_connection
and
https://nornir.readthedocs.io/en/latest/api/nornir/core/inventory.html#nornir.core.inventory.Host.close_connections
and
https://nornir.readthedocs.io/en/latest/api/nornir/core/__init__.html#nornir.core.__init__.Nornir.close_connections
nornir/docs/howto/handling_connections.ipynb
Line 122 in 95ef20f
https://nornir.readthedocs.io/en/latest/api/nornir/core/inventory.html#nornir.core.inventory.Host.open_connection
The text was updated successfully, but these errors were encountered: