Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage values incorrect for some armor #96

Open
CosmicHitman opened this issue Aug 22, 2022 · 3 comments
Open

Coverage values incorrect for some armor #96

CosmicHitman opened this issue Aug 22, 2022 · 3 comments

Comments

@CosmicHitman
Copy link

CosmicHitman commented Aug 22, 2022

There are a few bugs with the display of armor statistics right now (see picture below). I have tried using other browsers to see if that fixed the issue, but it still remained. Bugs included the following seen in the entry for "T-Shirt":

  • Coverage values are displayed all over the place and include values not in the JSON (150%, for example). Further, these values are sometimes completely nonsensical (214% coverage for boxer shorts, for example).
  • Material has no "Material" label and is displayed vertically (see the word "Cotton" in the picture).
    • Correction: Vertical material display was intentional, and the label is not actually needed.
  • The label "Protection" is separated from the actual values by a few rows.
    • Correction: I understand where the label is positioned better now. This is actually in the right place, so never mind.

Here is a photo of what I am talking about:
image

@nornagon
Copy link
Owner

Coverage values being wrong is certainly something I want to fix. The materials being displayed vertically is intentional; if they are displayed horizontally then items with many materials won't fit on the screen (e.g. https://nornagon.github.io/cdda-guide/#/item/armor_ch_chestplate).

tbh this isn't a terribly satisfying solution, but I haven't yet come up with a better one. Probably at some point I'll do a color-coding system with a key, and maybe I'll have it only kick in when there is more than one material. But: it's not a bug 😅

@nornagon
Copy link
Owner

(fwiw, the vertical text looks a lot better in Japanese! 🤣)

image

@CosmicHitman
Copy link
Author

I understand. I'll adjust the initial issue comment then.

@CosmicHitman CosmicHitman changed the title UI errors for armor entry of worn items UI error for armor entry of worn items Aug 24, 2022
@nornagon nornagon changed the title UI error for armor entry of worn items Coverage values incorrect for some armor Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants