mp4再生で半透明になる問題修正 #24
Open
mp4再生で半透明になる問題修正 #24
+107
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiping192
force-pushed
the
hotfix/mp4-Transparent-bug
branch
from
4d3bd2d
to
42c893e
Compare
noppefoxwolf
requested changes
Jan 27, 2022
| @@ -22,7 +22,8 @@ open class PlayerView: UIView { | |||
| private let renderQueue: DispatchQueue = .global(qos: .userInitiated) | |||
| private let commandQueue: MTLCommandQueue | |||
| private let textureCache: CVMetalTextureCache | |||
| private let pipelineState: MTLRenderPipelineState | |||
| private let mp4PipelineState: MTLRenderPipelineState | |||
There was a problem hiding this comment.
pipelineは常に１つのみを保持するようにしてください
There was a problem hiding this comment.
PlayerViewインスタンスが作ったらmp4,hevcどっちでも再生可能なので２つ用意する必要があるが、どこか勘違いしてました？ もしくはlazy initか
There was a problem hiding this comment.
将来的にPlayerViewとPlayer・Assetに分割するのでこの実装のままでもOKとします。
ただし変数名に関してはビデオフォーマットではなくシェーダの実態を表す名前にしてください。
| baseCbCrTexture.sample(colorSampler, in.texCoords).rg, | ||
| 1.0f); | ||
| // yuv video range to full range | ||
| baseYUVColor.r = (baseYUVColor.r - (16.0f/255.0f)) * (255.0f/(235.0f-16.0f)); |
There was a problem hiding this comment.
フルレンジのmp4を読み込んだ場合に意図しない変換が行われるように見えます。
There was a problem hiding this comment.
range shader内で判定できないので、asset読み込みで指定しないといけないが、それであってますか？
There was a problem hiding this comment.
あってます、レンダリング前に判断して分岐する必要があります。
There was a problem hiding this comment.
動画読み込み時にPixelFormatType明示的にvideo rangeに指定しました
huiping192
force-pushed
the
hotfix/mp4-Transparent-bug
branch
3 times, most recently
from
530c11f
to
bb58acc
Compare
thread blockされたときにメモリー使用量急に増えないようにした
* mp4再生で半透明になる問題
huiping192
force-pushed
the
hotfix/mp4-Transparent-bug
branch
from
bb58acc
to
4e7ccf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultのPixelFormatが kCVPixelFormatType_420YpCbCr8BiPlanarVideoRangeになっていて、rangeとしては(luma=[16,235] chroma=[16,240])のため、alpha用のr値が0,255になれなかった問題。
metal部分でrange変更追加して修正.
hevcのalpha部分は修正不要なので、処理わけるようにした