Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom with two fingers not work when document is scrolled #6950

Closed
5 of 6 tasks
JanPavlin234 opened this issue Aug 18, 2023 · 0 comments · May be fixed by abhishekbedi/framework7#1, Aarod23/nys-site#1, wierza/Team-project#148 or TaylorBundy/swiper#4

Comments

@JanPavlin234
Copy link

JanPavlin234 commented Aug 18, 2023

Check that this is really a bug

  • I confirm

Reproduction link

https://znrm.cz/swiper.html

Bug description

Zoom works fine when swiper is on position 0,0 at document. But when window.scrollY= 10000px zoom not works fine.
BUG is in ducntion getScaleOrigin()

FIX is here:
function getScaleOrigin() {
if (evCache.length < 2) return {
x: null,
y: null
};
const box = gesture.imageEl.getBoundingClientRect();
const scrollY = window.scrollY; // FIX
const scrollX = window.scrollX; // FIX
return [(evCache[0].pageX + (evCache[1].pageX - evCache[0].pageX) / 2 - box.x - scrollX) / currentScale, (evCache[0].pageY + (evCache[1].pageY - evCache[0].pageY) / 2 - box.y - scrollY) / currentScale]; // FIX
}

Expected Behavior

No response

Actual Behavior

No response

Swiper version

10

Platform/Target and Browser Versions

Mobile

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment