global in current amd/umd wrapper undefined in strict mode

[DanielRuf]

In specific scenarios the global variable in the generated amd/umd wrapper is undefined.
Normally it should be window and most libraries need a if(global === undefined && window!== undefined) global = window; to fix this.

This is a (multiple allowed):

• bug

• enhancement

• feature-discussion (RFC)

• Swiper Version: 4.1.6

• Platform/Target and Browser Versions: macOS.

What you did

EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE. (todo)

Expected Behavior

EXPLAIN WHAT IS TO BE EXPECTED, HERE. (todo)

Actual Behavior

EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE. (todo)

[DanielRuf]

Something like bebraw/libumd@f43a331 is needed.

dimsemenov/PhotoSwipe#1413

[DanielRuf]

More references:

fians/Waves#181
jonathantneal/svg4everybody#162

[nolimits4web]

This is actually UMD definition which should work correct in most of cases where it is used correctly. Can you show me an example of such env where it will throw an error?

[nolimits4web]

If you mean in something like this:

function () {
  'use strict';
  // ... full swiper.js source code here
}

Then it will throw an error, but i would say it is a wrong usage rather then UMD issue

[DanielRuf]

You can ask @bebraw of libumd as there is also this fix ;-)

[mikestreety]

I can confirm this solved an issue for me where I didn't want to install via node_modules and was just including the downloaded file in my Vue project. Thanks @DanielRuf.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed due to inactivity. If this issue is still actual, please, create the new one.