fix(modules/a11y): filter out falsy pagination elems #7201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6823 I am noticing intermittent exceptions generated in the
destroy()
method of thea11y
module, in this case where theel
argument to the callback passed topaginationEl.forEach
isundefined
and so the attempt to.removeEventListener
is aTypeError
. As in the previous case, because these exceptions are thrown from within an event handler they are uncatchable and crash the entire page.It looks like the use of
makeElementsArray
, which filters out such falsy elements (and should otherwise behave identically to the existing code), is also required with the pagination element.