Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): events types #5424

Merged
merged 2 commits into from
Feb 3, 2022
Merged

feat(angular): events types #5424

merged 2 commits into from
Feb 3, 2022

Conversation

vltansky
Copy link
Collaborator

@vltansky vltansky commented Feb 2, 2022

exported as SwiperNgEvents.
Have better naming suggestion?

@nolimits4web
Copy link
Owner

Let's rename it to just Events

@vltansky
Copy link
Collaborator Author

vltansky commented Feb 3, 2022

Difficult for autoimport?

@nolimits4web
Copy link
Owner

Then SwiperEvents ? :)

@vltansky
Copy link
Collaborator Author

vltansky commented Feb 3, 2022

then it would be the same as Cores Swiper Events:)
Maybe SwiperEventsParams and export it from swiper/types instead of angular?

@nolimits4web
Copy link
Owner

then it would be the same as Cores Swiper Events:)

That is not a problem, as you anyway import it from swiper/angular and it is not needed anywhere else except in Angular

@nolimits4web
Copy link
Owner

Maybe then just EventsParams

@nolimits4web nolimits4web merged commit d8631d8 into nolimits4web:master Feb 3, 2022
@nolimits4web
Copy link
Owner

Can you also send a PR for Angular docs?

@vltansky
Copy link
Collaborator Author

vltansky commented Feb 3, 2022

done
nolimits4web/swiper-website#234

@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vltansky @nolimits4web