Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming ambiguity between component and type breaks the swiper #5141

Closed
5 of 6 tasks
alicerocheman opened this issue Oct 28, 2021 · 0 comments
Closed
5 of 6 tasks

Naming ambiguity between component and type breaks the swiper #5141

alicerocheman opened this issue Oct 28, 2021 · 0 comments
Labels

Comments

@alicerocheman
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/s/adoring-grothendieck-xbbgd?file=/src/Slide.tsx

Bug description

The SwiperSlide props type and the SwiperSlide component are exported with the same name. (same for Swiper props type and Swiper component)

This provokes an ambiguity which breaks the swiper.

Expected Behavior

Different naming for the type and the component

Actual Behavior

Same naming for the type and the component

Swiper version

7.0.9

Platform/Target and Browser Versions

macOs BigSur 11.6 / Chrome 94

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant