Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.destroy() throwing Error with progressbar in swiper7 #4859

Closed
5 of 6 tasks
Joscha95 opened this issue Aug 25, 2021 · 1 comment
Closed
5 of 6 tasks

swiper.destroy() throwing Error with progressbar in swiper7 #4859

Joscha95 opened this issue Aug 25, 2021 · 1 comment

Comments

@Joscha95
Copy link

Joscha95 commented Aug 25, 2021

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/s/swiper-pagination-progress-forked-6nbel?file=/index.html:2544-2604

Bug description

I think I ran into a bug, that has never occurred to me before the update:
I have a swiper with a progressbar and when I call swiper.destroy() on it I get an error in the console:
Screenshot 2021-08-25 at 18 36 56

I checked it in the demo and just pasted setTimeout(() => {swiper.destroy();}, 3000); at line 100 after the swiper init.
If it has bullets it all works fine.
(note that the screenshot is from my project, not the demo, just to avoid confusion)

Expected Behavior

No response

Actual Behavior

No response

Swiper version

7.0.0

Platform/Target and Browser Versions

Safari 14.0.1
Firefox 91.0.2

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@Joscha95 Joscha95 changed the title swiper.destroy() not working with progressbar in swiper7 swiper.destroy() throwing Error with progressbar in swiper7 Aug 25, 2021
@Joscha95
Copy link
Author

thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant