fix(core): don't extend html elements #4691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular SSR build error:
run
npm run angular:dev:ssr
onmaster
to reproduce.extend()
function fromsrc/utils.js
passing object fromHTMLElement
type to itself as it recognizes it as Object (that is technically right). That's leading to recursion, as HTMLElement has a lot of inner objects.This PR adds check
!(nextSource instanceof HTMLElement)
toextend()
function to skip HTML Elements from extending.closes #4576