-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aXe testing to automated CI tests #513
Comments
The plugin uses an older version of aXe, but there are two pull requests opened if the latest version is needed. |
Interestingly it seems aXe cannot test Pinafore. I've tried I thought maybe it was due to CSP, but I disabled it and it still fails. On the bright side, Lighthouse does seem to be working so perhaps this should be closed in favor of #746 |
axe works for me now, although it's finding some false positives: dequelabs/axe-core#1176 (comment) |
Want to get this going to ensure when we resolve contrast issues we dont accidentally regress so adding to milestone for WCAG compliance. |
@NickColley Thanks a lot. AA sounds totally achievable for us. (My understanding is that AAA is more like a "stretch goal" so not necessarily something we need to target?) |
Yeah some things you want to try and aim for AAA but sometimes it's actually impossible to meet all to AAA. AA is what the main legislation for the EU and UK Public Sector Accessibility Regulations align with, and is becoming a sort of defacto baseline, and definitely achievable for us. |
Just a note on false positives, it's pretty common for axe to throw up issues that are false positives so what we'd do in this case is disable the rule that is being thrown and document why. This may also be a good way to introduce the tests as well, in a sort of 'failing test' situation where we add axe and raise github issues for each disabled rule. |
We can use this testcafe plugin: https://github.com/helen-dikareva/axe-testcafe
The text was updated successfully, but these errors were encountered: