Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building danm with default CRI #254

Open
prnvkv opened this issue May 19, 2021 · 2 comments
Open

Support building danm with default CRI #254

prnvkv opened this issue May 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@prnvkv
Copy link

prnvkv commented May 19, 2021

Is this a BUG REPORT or FEATURE REQUEST?:
Feature request

Uncomment only one, leave it on its own line:
feature
Currently when we try to use build.sh when neither docker or podman is present, it throws error :
The build process requires docker or buildah/podman installed. Please install any of these and make sure these are executable
Terminating with error!

What happened:
When k3s is installed without docker or podman, and try to use danm plugin, it throws the error:
The build process requires docker or buildah/podman installed. Please install any of these and make sure these are executable
Terminating with error!

What you expected to happen:
No error
How to reproduce it:
Install k3s and run build.sh from danm

@Levovar Levovar changed the title Support danm with default CRI Support building danm with default CRI May 19, 2021
@Levovar Levovar added the enhancement New feature or request label May 19, 2021
@Levovar
Copy link
Collaborator

Levovar commented May 19, 2021

just for my reference, what does your environment have? containerd?

@prnvkv
Copy link
Author

prnvkv commented May 19, 2021

@Levovar Thanks for addressing this issue.
Yes, it runs with containerd which is packaged along with k3s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants