Provided Types virtualization (#2)

nojaf · May 11, 2023 · a1a3316 · a1a3316
1 parent a3fb799
commit a1a3316
Show file tree

Hide file tree

Showing 7 changed files with 613 additions and 298 deletions.
diff --git a/src/Compiler/Checking/CheckDeclarations.fs b/src/Compiler/Checking/CheckDeclarations.fs
@@ -2855,7 +2855,7 @@ module EstablishTypeDefinitionCores =
             let ctxt = ProvidedTypeContext.Create(lookupILTypeRef, lookupTyconRef)
 
             // Create a new provided type which captures the reverse-remapping tables.
-            let theRootTypeWithRemapping = theRootType.PApply ((fun x -> ProvidedType.ApplyContext(x, ctxt)), m)
+            let theRootTypeWithRemapping = theRootType.PApply ((fun x -> x.ApplyContext(ctxt)), m)
 
             let isRootGenerated, rootProvAssemStaticLinkInfoOpt = 
                 let stRootAssembly = theRootTypeWithRemapping.PApply((fun st -> st.Assembly), m)

diff --git a/src/Compiler/Driver/CompilerImports.fs b/src/Compiler/Driver/CompilerImports.fs
@@ -1884,13 +1884,7 @@ and [<Sealed>] TcImports
                             // NOTE: The types provided by GetTypes() are available for name resolution
                             // when the namespace is "opened". This is part of the specification of the language
                             // feature.
-                            let tys =
-                                providedNamespace.PApplyArray((fun provider -> provider.GetTypes()), "GetTypes", m)
-
-                            let ptys =
-                                [|
-                                    for ty in tys -> ty.PApply((fun ty -> ty |> ProvidedType.CreateNoContext), m)
-                                |]
+                            let ptys = providedNamespace.PApplyArray(GetProvidedTypes, "GetTypes", m)
 
                             for st in ptys do
                                 tcImportsStrong.InjectProvidedNamespaceOrTypeIntoEntity(

diff --git a/src/Compiler/TypedTree/TypeProviders.fs b/src/Compiler/TypedTree/TypeProviders.fs