remove typechecks from cache on file close (ionide#1187)

nojaf · Nov 3, 2023 · 0bf7ad9 · 0bf7ad9
1 parent 378ece1
commit 0bf7ad9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/FsAutoComplete.Core/CompilerServiceInterface.fs b/src/FsAutoComplete.Core/CompilerServiceInterface.fs
@@ -41,7 +41,6 @@ type FSharpCompilerServiceChecker(hasAnalyzers, typecheckCacheSize, parallelRefe
 
   let mutable lastCheckResults: IMemoryCache = memoryCache ()
 
-
   let checkerLogger = LogProvider.getLoggerByName "Checker"
   let optsLogger = LogProvider.getLoggerByName "Opts"
 
@@ -244,6 +243,8 @@ type FSharpCompilerServiceChecker(hasAnalyzers, typecheckCacheSize, parallelRefe
   member __.ScriptTypecheckRequirementsChanged =
     scriptTypecheckRequirementsChanged.Publish
 
+  member _.RemoveFileFromCache(file: string<LocalPath>) = lastCheckResults.Remove(file)
+
   /// This function is called when the entire environment is known to have changed for reasons not encoded in the ProjectOptions of any project/compilation.
   member _.ClearCaches() =
     lastCheckResults.Dispose()

diff --git a/src/FsAutoComplete.Core/CompilerServiceInterface.fsi b/src/FsAutoComplete.Core/CompilerServiceInterface.fsi
@@ -30,6 +30,9 @@ type FSharpCompilerServiceChecker =
     file: string<LocalPath> * source: ISourceText * tfm: FSIRefs.TFM -> Async<FSharpProjectOptions>
 
   member ScriptTypecheckRequirementsChanged: IEvent<unit>
+
+  member RemoveFileFromCache: file: string<LocalPath> -> unit
+
   /// This function is called when the entire environment is known to have changed for reasons not encoded in the ProjectOptions of any project/compilation.
   member ClearCaches: unit -> unit
 

diff --git a/src/FsAutoComplete/LspServers/AdaptiveServerState.fs b/src/FsAutoComplete/LspServers/AdaptiveServerState.fs
@@ -1814,6 +1814,8 @@ type AdaptiveState(lspClient: FSharpLspClient, sourceTextFactory: ISourceTextFac
 
         |> AsyncAVal.forceAsync
 
+      (AVal.force checker).RemoveFileFromCache(filePath)
+
       transact (fun () ->
         openFiles.Remove filePath |> ignore<bool>