Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Noir benchmarking #5

Open
2 tasks
TomAFrench opened this issue May 3, 2024 · 3 comments
Open
2 tasks

Remove Noir benchmarking #5

TomAFrench opened this issue May 3, 2024 · 3 comments
Assignees

Comments

@TomAFrench
Copy link
Member

TomAFrench commented May 3, 2024

Prerequisites

  1. benchmarking documentation
  2. TomAFrench

Currently nargo handles proving/verifying (although mostly as a passthrough to the backend), as part of noir-lang/noir#4960 we're removing this so it doesn't make any sense to benchmark a "noir proof". Instead backends should implement benchmarks for generating proofs from ACIR (started in AztecProtocol/aztec-packages#6155).

This repository then only needs to produce a report for circom proofs for a set to programs equivalent to the Noir programs which are used for benchmarks.

@TomAFrench
Copy link
Member Author

I do think that won't really have need for rust in this repository. We could likely get away with just having a shell script iterating through the circom projects and making the necessary calls to circom/snarkjs.

@Savio-Sou
Copy link
Contributor

Savio-Sou commented May 23, 2024

Keeping all benchmarks in one place would be very helpful in minimizing barriers to access information and modify benchmarks though.

As it stands, this repo feels like a great framework for less technical folks (e.g. me, Dev Rel) to also modify and extend tests directly, without the need to funnel through Engineering. Not sure if that carries over if folks have to touch the more complicated Barretenberg repo and ACVM folder instead for changes.

If the intention is to minimize backend specific code under noir-lang, transferring this repo as is to AztecPackages and continue from there seems like a better way out.

@Savio-Sou
Copy link
Contributor

Circling back from further conversations, the benchmarking suites in aztec-packages / noir are useful for development of the language and barretenberg itself.

Using the same suites for community-facing benchmarks avoids the need to maintain multiple suites serving largely similar functionalities.

Updated body of this Issue with tasks to bring those suites into a useful state for community-facing benchmarking. We shall aim for tackling this Issue only when they are cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants