Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add support for feature flags #37

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Conversation

Maddiaa0
Copy link
Member

Description

Adds support to noirup to install from source or from a git repo with specific feature flags enabled.

Usage:

The installer for Nargo.
Update or revert to a specific Nargo version with ease.
USAGE:
    noirup <OPTIONS>
OPTIONS:
    -h, --help      Print help information
    -v, --version   Install a specific version
    -b, --branch    Install a specific branch
    -P, --pr        Install a specific Pull Request
    -C, --commit    Install a specific commit
    -r, --repo      Install from a remote GitHub repo (uses default branch if no other options are set)
    -p, --path      Install a local repository
    -f, --features  Activates feature flags when building from source

Example:
If installing from a local repo with the aztec feature flag enabled:

noirup -p . -f aztec

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes but looks good.

noirup Outdated Show resolved Hide resolved
noirup Outdated Show resolved Hide resolved
noirup Outdated Show resolved Hide resolved
noirup Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@Savio-Sou
Copy link
Contributor

@Maddiaa0 good to re-review?

@Maddiaa0
Copy link
Member Author

I think so

@Savio-Sou Savio-Sou requested a review from TomAFrench August 31, 2023 07:14
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench merged commit 18d911b into main Sep 5, 2023
@TomAFrench TomAFrench deleted the md/feature-flags branch September 5, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants