Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Checkout the project at release tag to find files to upload #29

Merged
merged 1 commit into from
May 22, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented May 22, 2023

Related issue(s)

Resolves (link to issue)

Description

Summary of changes

I noticed that the CI failed because it couldn't locate any files to upload. This happens because the project is not checked out in the job.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@phated phated requested a review from TomAFrench May 22, 2023 15:49
@phated phated changed the title fix: Checkout the project at release tag to find files to upload fix(ci): Checkout the project at release tag to find files to upload May 22, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I manually uploaded these last time and forgot to go back and fix this.

@TomAFrench TomAFrench merged commit 82f68ff into main May 22, 2023
@phated phated deleted the phated/checkout-after-release branch May 22, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants