-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for base64url alphabet #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saleel I have questions about 2 points:
|
grjte
force-pushed
the
feat/multi-alphabet
branch
from
October 29, 2024 11:40
145825b
to
36e5a54
Compare
Looks good 🚀
|
- note: based on profiling, it seems that the previous costs were wrong and that the current costs have been the same since the reversed encoding/decoding was fixed in commit cc5b18a.
grjte
force-pushed
the
feat/multi-alphabet
branch
from
October 30, 2024 09:42
36e5a54
to
3fc82c6
Compare
Thanks @saleel! I've updated with those 2 changes |
grjte
force-pushed
the
feat/multi-alphabet
branch
from
October 30, 2024 17:58
3fc82c6
to
291426b
Compare
grjte
force-pushed
the
feat/multi-alphabet
branch
from
October 30, 2024 18:01
291426b
to
69cb9e9
Compare
saleel
approved these changes
Oct 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes the process of making the library configurable for padded/unpadded inputs and the commonly required base64 alphabets (standard and
base64url
).Problem*
Resolves #15 and also addresses asserts for input/output lengths during decoding as mentioned in #19.
Summary*
PR Checklist*
cargo fmt
on default settings.