Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nargo): migrate to clap 4 and use derived interface #842

Merged
merged 8 commits into from
Feb 17, 2023
Merged

chore(nargo): migrate to clap 4 and use derived interface #842

merged 8 commits into from
Feb 17, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #841

Description

Summary of changes

clap has been updated to 4.1.4 from 2.33.3 and I've switched it over to use the derived API. This allows us to create the CLI in a more declarative manner while adding extra structure to the CLI's arguments.

The allow_warnings and show_ssa flags are still done on a per-command basis but I'd like to deduplicate them in future.

Dependency additions / changes

clap has been updated to 4.1.4 from 2.33.3

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench changed the title Migrate to clap 4 and use derived interface chore: migrate to clap 4 and use derived interface Feb 14, 2023
@TomAFrench TomAFrench changed the title chore: migrate to clap 4 and use derived interface chore(nargo): migrate to clap 4 and use derived interface Feb 14, 2023
@TomAFrench
Merge branch 'master' into update-clap
d67fbef 
* master:
  chore(ci): Add release token to enable runs against release PR (#840)
  feat(ssa): array sort (#754)
  chore: update readme (#811)
  chore: fix clippy (#825)
  chore: remove stale comment on HirFunction.unchecked_from_expr (#827)
@TomAFrench
Merge branch 'master' into update-clap
a9ad0a5 
* master:
  feat(nargo): add flag to verify created proofs (#737)
  chore: Add display for binaryop (#839)
  chore(ssa): per array memory map (#832)
  chore: remove unwanted print of Ok(<path>) in nargo compile (#843)
jfecher
jfecher reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench
Copy link
Member Author

Considering the changes this makes to the CLI interface, we should wait until #765 is in before merging this. We should try to do it promptly afterwards though as we're going to keep getting merge conflicts on this as it touches so much of the CLI.

@kevaundray kevaundray added this pull request to the merge queue Feb 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2023
@kevaundray kevaundray added this pull request to the merge queue Feb 17, 2023
Merged via the queue into master with commit 4d3d35b Feb 17, 2023
@kevaundray kevaundray deleted the update-clap branch February 17, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to clap's derived CLI interface
3 participants
@TomAFrench @jfecher @kevaundray