Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Make file manager read-only to the compiler #3760

Merged
merged 36 commits into from
Dec 14, 2023
Merged

chore!: Make file manager read-only to the compiler #3760

merged 36 commits into from
Dec 14, 2023

Commits on Dec 10, 2023

  1. make find_module be an immutable reference

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    7e0a3d1 View commit details
    Browse the repository at this point in the history

  2. add method in nargo that pre-populates the FileManager

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    b2ff05b View commit details
    Browse the repository at this point in the history

  3. change add_file to name_to_id -- we assume that the file manager ha… 

    …s already been populated
    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    5592348 View commit details
    Browse the repository at this point in the history

  4. cargo

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d5fd4e0 View commit details
    Browse the repository at this point in the history

  5. Update tooling/nargo/src/lib.rs

    @kevaundray
    kevaundray authored Dec 10, 2023
    Configuration menu
    Copy the full SHA
    2f137b7 View commit details
    Browse the repository at this point in the history

  6. add a method in file manager that allows us to add a file with its so… 

    …urce
    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    41ae81f View commit details
    Browse the repository at this point in the history

  7. add deprecation TODO to file_reader

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    c7f576c View commit details
    Browse the repository at this point in the history

  8. add stdlib file in noirc_driver that returns the stdlib paths alongsi… 

    …de their source code
    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    a2460e6 View commit details
    Browse the repository at this point in the history

  9. add the contents of the stdlib whenever we call prepare_crate

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    270a0f4 View commit details
    Browse the repository at this point in the history

  10. cargo

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    52d33a5 View commit details
    Browse the repository at this point in the history

  11. cargo fmt

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    a38c27c View commit details
    Browse the repository at this point in the history

  12. move tempfile to dev dependencies

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    6a5bf33 View commit details
    Browse the repository at this point in the history

  13. add files into file manager in test since find_module does not add fi… 

    …les into the file manager anymore
    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    f72ce99 View commit details
    Browse the repository at this point in the history

  14. insert all files for this packages dependencies into the file manager… 

    … too
    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    b30ad54 View commit details
    Browse the repository at this point in the history

  15. cargo fmt

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    15a94ee View commit details
    Browse the repository at this point in the history

  16. remove un-needed fully qualified path

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4599361 View commit details
    Browse the repository at this point in the history

  17. Add note on stdlib

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    f20109e View commit details
    Browse the repository at this point in the history

  18. cargo fmt

    @kevaundray
    kevaundray committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4413350 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. add comment to process_dep_graph and fix setup_test_context

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d6a24e8 View commit details
    Browse the repository at this point in the history

  2. replace expect with unwrap_or_else: expect doesn't allow you to add p… 

    …laceholders like panic! and format! do
    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    552a4dd View commit details
    Browse the repository at this point in the history

  3. try: add a PathToFileSourceMap object

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3f8551b View commit details
    Browse the repository at this point in the history

  4. remove extraneous forward slash

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    dd94b46 View commit details
    Browse the repository at this point in the history

  5. add file_manager_with_source_map method so we ensure that FileManager… 

    … always has its data
    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3495de5 View commit details
    Browse the repository at this point in the history

  6. add expect

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    851fab1 View commit details
    Browse the repository at this point in the history

  7. fix node tests

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3cd35fd View commit details
    Browse the repository at this point in the history

  8. fix browser tests and naming nit

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d2590d5 View commit details
    Browse the repository at this point in the history

  9. chore!: Remove add_file and file_reader from FileManager (#3762) 

    # Description

This removes FileManager from add_file and uses add_file_with_source

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
    @kevaundray
    kevaundray authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5b867d5 View commit details
    Browse the repository at this point in the history

  10. Update compiler/fm/src/lib.rs

    @kevaundray
    kevaundray authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5ebf83a View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into kw/make-fm-read-only

    @kevaundray
    kevaundray authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    7a787d7 View commit details
    Browse the repository at this point in the history

  12. file_reader is no longer being used

    @kevaundray
    kevaundray committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    419273e View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into kw/make-fm-read-only

    @kevaundray
    kevaundray authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d120852 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. chore: add simple doc comments for add_file_with_source methods

    @TomAFrench
    TomAFrench committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1e9ac97 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into kw/make-fm-read-only

    @kevaundray
    kevaundray committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    cc92c07 View commit details
    Browse the repository at this point in the history

  3. Update tooling/nargo/src/lib.rs 

    Co-authored-by: Tom French <[email protected]>
    @kevaundray @TomAFrench
    kevaundray and TomAFrench authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9aa0bb7 View commit details
    Browse the repository at this point in the history

  4. read entry_path and get all files in its parent

    @kevaundray
    kevaundray committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3e26e3c View commit details
    Browse the repository at this point in the history

  5. clippy

    @kevaundray
    kevaundray committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0b53332 View commit details
    Browse the repository at this point in the history