Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compute_note_hash_and_nullifier compiler check #3351

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: compute_note_hash_and_nullifier compiler check #3351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
018703b
fix
benesjan Oct 30, 2023
35264f5
Merge branch 'master' into janb/copute_note_hash_check_fix
benesjan Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/noirc_frontend/src/hir/aztec_library.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ fn transform_module(
// Check for a user defined storage struct
let storage_defined = check_for_storage_definition(&module);

if storage_defined && check_for_compute_note_hash_and_nullifier_definition(&module) {
if storage_defined && !check_for_compute_note_hash_and_nullifier_definition(&module) {
let crate_graph = &context.crate_graph[crate_id];
return Err((
DefCollectorErrorKind::AztecComputeNoteHashAndNullifierNotFound {
Expand Down
1 change: 1 addition & 0 deletions compiler/noirc_frontend/src/hir/def_collector/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
TraitImplOrphaned { span: Span },

// Aztec feature flag errors
// TODO(benesjan): https://github.com/AztecProtocol/aztec-packages/issues/2905

Check warning on line 70 in compiler/noirc_frontend/src/hir/def_collector/errors.rs

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck 

Unknown word (benesjan)
#[cfg(feature = "aztec")]
#[error("Aztec dependency not found. Please add aztec as a dependency in your Cargo.toml")]
AztecNotFound {},
Expand Down
Loading