Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format integration tests #3257

Merged
merged 4 commits into from Oct 27, 2023
Merged

chore: format integration tests #3257

merged 4 commits into from Oct 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2023

Description

find . -type f -name Nargo.toml -exec sh -c 'echo "Project Name in {}:"; cd "$(dirname "{}")"; cargo r -- fmt' \;

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost marked this pull request as ready for review October 24, 2023 14:43
@kevaundray
Copy link
Contributor

@TomAFrench noticed that this is throwing a panic on 6_array -- it seems like your command ignores failures

@ghost
Copy link
Author

ghost commented Oct 24, 2023

@kevaundray

Panic happens because of desugaring for. Now you can probably try marking such blocks and just skipping them.
The formatter recognizes from the AST that we are in a block and wants to get a comment, but in reality, there is a 'for' loop there.

[tooling/nargo_fmt/src/visitor/expr.rs:302] self.slice(block_span) = "for y_elem in y {\n        for x_elem in x {\n            assert(x_elem != y_elem);\n        }\n    }"

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Lets just remove a few files from this PR and we can format those later once a few issues in the formatter are fixed.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Oct 27, 2023
Merged via the queue into noir-lang:master with commit 5b2b1a8 Oct 27, 2023
29 checks passed
TomAFrench added a commit that referenced this pull request Oct 30, 2023
* master: (242 commits)
  chore(docs): Update Windows installation  (#3326)
  chore!: change stdlib function `pedersen` to `pedersen_commitment` (#3341)
  chore: add back algolia recrawler (#3332)
  chore: comment out algolia recrawler workflow as its failing master (#3331)
  chore: Modify single line if-else expression width threshold (#3329)
  feat: Expand trait impl overlap check to cover generic types (#3320)
  feat: Implement where clauses on impls (#3324)
  chore: builtin wrapping shift left (#3270)
  chore: format integration tests  (#3257)
  fix(3300): cache warnings into debug artefacts (#3313)
  fix(3275): activate brillig modulo test with negative integers (#3318)
  feat: Add check for overlapping generic traits (#3307)
  feat: Refactor debugger and separate core from UI (#3308)
  chore: recrawl docs on merge (#3306)
  chore: add bn254 attribute when needed in the stdlib (#3208)
  feat: add exports of JS black box solvers to noirJS (#3295)
  chore: upload acir artifacts as a github artifact (#3288)
  chore: bump bb version to 0.12.0 (#3304)
  chore(docs): Supplement descriptions for defaulting loop indices to be `u64` (#3237)
  chore: create publish-docs.yml (#3298)
  ...
@ghost ghost deleted the nargo_fmt branch November 23, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants