Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move wasm-bindgen dependency to noir_lsp #2916

Merged
merged 1 commit into from
Sep 29, 2023
Merged

chore: move wasm-bindgen dependency to noir_lsp #2916

merged 1 commit into from
Sep 29, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This should have been done as part of #2649

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore: move wasm-bindgen dependency to noir_lsp chore: move wasm-bindgen dependency to noir_lsp Sep 29, 2023
@kevaundray kevaundray added this pull request to the merge queue Sep 29, 2023
Merged via the queue into master with commit d942de8 Sep 29, 2023
26 checks passed
@kevaundray kevaundray deleted the tf/move-wasm-bindgen-dep branch September 29, 2023 23:43
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
@TomAFrench @Sakapoi
chore: move wasm-bindgen dependency to noir_lsp (noir-lang#2916)
f933804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray