chore: remove messagepack serialization logic #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Sep 28, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
* master: chore: remove messagepack serialization logic (#2865) chore: improve workspace clean (#2870) fix: finer bit size in bound constrain (#2869) feat: Contract events in artifacts (#2873) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868) chore(noir_js): remove unnecessary input validation in JS (#2841) chore: build yarn packages in parallel (#2867) chore(ci): remove `toml2json` dependency (#2862) chore: fix infinite loop in yarn workspace cleaning (#2863)
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
* master: chore: remove messagepack serialization logic (#2865) chore: improve workspace clean (#2870) fix: finer bit size in bound constrain (#2869) feat: Contract events in artifacts (#2873) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868) chore(noir_js): remove unnecessary input validation in JS (#2841) chore: build yarn packages in parallel (#2867) chore(ci): remove `toml2json` dependency (#2862) chore: fix infinite loop in yarn workspace cleaning (#2863)
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
* master: chore: remove messagepack serialization logic (#2865) chore: improve workspace clean (#2870) fix: finer bit size in bound constrain (#2869) feat: Contract events in artifacts (#2873) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868)
TomAFrench
added a commit
that referenced
this pull request
Sep 28, 2023
* master: chore: remove messagepack serialization logic (#2865) chore: improve workspace clean (#2870) fix: finer bit size in bound constrain (#2869) feat: Contract events in artifacts (#2873) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875)
TomAFrench
added a commit
that referenced
this pull request
Sep 29, 2023
* master: (85 commits) feat: Add noir types package (#2893) chore: add scripts for testing (#2890) chore(noir-js): Add program API (#2856) feat(traits): multi module support for traits (#2844) chore(noir): Release (master) (#2879) chore: set up noir_js in integration tests (#2871) chore!: update to `bb` version 0.7.3 (#2729) chore: remove additional yarn install in `acvm_js` (#2885) chore: remove messagepack serialization logic (#2865) chore: improve workspace clean (#2870) fix: finer bit size in bound constrain (#2869) feat: Contract events in artifacts (#2873) chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868) chore(noir_js): remove unnecessary input validation in JS (#2841) chore: build yarn packages in parallel (#2867) chore(ci): remove `toml2json` dependency (#2862) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This logic is now incompatible with the entirety of the Noir ecosystem so there's no reason to include it anymore.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.