Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not simplify mod or div #2741

Closed
wants to merge 13 commits into from
Closed

fix: do not simplify mod or div #2741

wants to merge 13 commits into from

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #2584

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor

Can you add a regression test?

@guipublic
Copy link
Contributor Author

Can you add a regression test?

Done

@kevaundray kevaundray self-assigned this Sep 25, 2023
@kevaundray
Copy link
Contributor

Seems sha2_block is working by itself -- I've put back the other examples and merged master into the branch again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused divide or modulo by zero passes execution instead of failing
2 participants