Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compile circuits and query circuit sizes in parallel for nargo info #2665

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR applies the changes made in #2612 to nargo info.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Base automatically changed from parallel-workspace-compilation to master September 12, 2023 16:43
@TomAFrench TomAFrench changed the base branch from master to tf/embedded-debug-info September 12, 2023 17:45
@TomAFrench
Copy link
Member Author

Rebased this on top of #2666 as that allows a bunch of simplifications.

Base automatically changed from tf/embedded-debug-info to master September 12, 2023 19:41
* master:
  chore: Embed a file map into `CompiledProgram`/`CompiledContract` (#2666)
* master:
  chore!: Restrict packages to contain at most a single contract (#2668)
@TomAFrench TomAFrench marked this pull request as ready for review September 12, 2023 21:56
@TomAFrench TomAFrench changed the title feat: compile circuits for nargo info in parallel feat: compile circuits and query circuit size in parallel for nargo info Sep 12, 2023
@TomAFrench TomAFrench changed the title feat: compile circuits and query circuit size in parallel for nargo info feat: compile circuits and query circuit sizes in parallel for nargo info Sep 12, 2023
@kevaundray kevaundray added this pull request to the merge queue Sep 13, 2023
Merged via the queue into master with commit f173c05 Sep 13, 2023
15 checks passed
@kevaundray kevaundray deleted the tf/parallel-workspace-info branch September 13, 2023 01:05
TomAFrench added a commit that referenced this pull request Sep 13, 2023
* master:
  chore: fix npm token for abi_wasm publishing (#2633)
  chore(ci): switch to using `Swatinem/rust-cache` action (#2671)
  feat: compile circuits and query circuit sizes in parallel for `nargo info` (#2665)
  chore(ci): use mock backend for all tests (#2670)
  chore!: Restrict packages to contain at most a single contract (#2668)
  chore: Embed a file map into `CompiledProgram`/`CompiledContract` (#2666)
  feat: Compile workspace packages in parallel (#2612)
  fix(wasm): Avoid requesting stdlib paths from the source-resolver (#2650)
  chore: add abi_wasm to release-please (#2664)
  chore: refactor `execute_cmd` (#2656)
  chore: defer reporting of errors until after compilation and optimization is finished (#2659)
  fix: fix compilation using `aztec` feature flag (#2663)
  fix: remove duplicate file extension in stack trace (#2655)
  chore: use `DebugArtifact`s instead of `FileManager` to report errors (#2641)
  chore: Fix clippy warnings for rust version 1.67.0 (#2661)
  fix(wasm): Apply transformation map to circuit debug information in `noir_wasm` (#2635)
  fix: Fix `update_acir` deleting all debug information (#2643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants