chore: pass in file reader to FileManager at runtime
#2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What overhead are you referring to? |
Rather than just calling the function which is currently defined at compile-time, it'll need to go through the extra layer of dealing with the |
kevaundray
reviewed
Sep 11, 2023
5 tasks
TomAFrench
force-pushed
the
tf/file-manager-closure
branch
from
bd1d1e0
to
e14d2a3
Compare
TomAFrench
changed the base branch from
master
to
tf/make-std-reading-arch-agnostic
Base automatically changed from
tf/make-std-reading-arch-agnostic
to
master
September 27, 2023 16:36
* master: chore: remove leftover files from `acvm-repo` (#2861) chore: miscellaneous ACVM fixups (#2864) chore(noir): Release (master) (#2875) fix: Remove cast for field comparisons in brillig (#2874) fix: remove duplication of code to load stdlib files (#2868) chore(noir_js): remove unnecessary input validation in JS (#2841) chore: build yarn packages in parallel (#2867) chore(ci): remove `toml2json` dependency (#2862) chore: fix infinite loop in yarn workspace cleaning (#2863)
kevaundray
previously approved these changes
Sep 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
kevaundray
approved these changes
Sep 29, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 29, 2023
* master: chore: pass in file reader to `FileManager` at runtime (#2649)
5 tasks
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Co-authored-by: kevaundray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Summary*
We currently conditionally compile how the
FileManagerreads in files based on the target architecture. If we were to pass this in as a boxed closure we could remove the need fornoir-source-resolverentirely.wasmwould then have full control on how to load Noir source.This will add some overhead to reading in files however so I'd be interested to hear any opinions one way or the other. I'm preferring this solution to a generic to avoid that spreading and making the whole compiler generic.
cc @phated @kevaundray
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.