fix: Modulo with divisor of zero should fail constraints

crates/nargo_cli/tests/compile_failure/div_by_zero_modulo/Nargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "div_by_zero_modulo"
+type = "bin"
+authors = [""]
+compiler_version = "0.10.5"
+
+[dependencies]

crates/nargo_cli/tests/compile_failure/div_by_zero_modulo/src/main.nr

@@ -0,0 +1,7 @@
+fn main() {
+    let a: u32 = 6;
+	let b = 3;
+	let c = 0;
+	let res = (a*b) % c;
+	assert(res != 5);
+}

crates/noirc_evaluator/src/ssa/ir/instruction.rs

@@ -631,10 +631,11 @@
         let operand_type = dfg.type_of_value(self.lhs);
 
         if let (Some(lhs), Some(rhs)) = (lhs, rhs) {
             // If the rhs of a division is zero, attempting to evaluate the divison will cause a compiler panic.
             // Thus, we do not evaluate this divison as we want to avoid triggering a panic,
             // and division by zero should be handled by laying down constraints during ACIR generation.
-            if matches!(self.operator, BinaryOp::Div) && rhs == FieldElement::zero() {
+            if matches!(self.operator, BinaryOp::Div | BinaryOp::Mod) && rhs == FieldElement::zero()
+            {
                 return SimplifyResult::None;
             }
             return match self.eval_constants(dfg, lhs, rhs, operand_type) {
@@ -781,7 +782,7 @@
 
                 // The divisor is being truncated into the type of the operand, which can potentially
                 // lead to the rhs being zero.
                 // If the rhs of a division is zero, attempting to evaluate the divison will cause a compiler panic.
                 // Thus, we do not evaluate the division in this method, as we want to avoid triggering a panic,
                 // and the operation should be handled by ACIR generation.
                 if matches!(self.operator, BinaryOp::Div) && rhs == 0 {