chore: implement eq_var in AcirContext to take advantage of optimizations
#2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the base branch from
use-equivalence-from-asserts
to
master
TomAFrench
changed the base branch from
master
to
use-equivalence-from-asserts
TomAFrench
changed the base branch from
use-equivalence-from-asserts
to
update-artifacts
TomAFrench
changed the base branch from
update-artifacts
to
use-equivalence-from-asserts
|
Unsure whether this does anything past the changes which I broke off into #2380. |
TomAFrench
force-pushed
the
use-equivalence-from-asserts
branch
from
97456e9
to
c66130d
Compare
TomAFrench
force-pushed
the
acir-var-eq
branch
from
6a3de72
to
81b4fa4
Compare
|
Closing as this increases circuit sizes if anything. Can maybe revisit this idea after #2137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR inlines
GeneratedAcir::is_equalintoAcirContext::eq_varand implements it in terms ofAcirVars so that we can take advantage of optimisations better.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.