Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): print ssa passes on flag only #1685

Merged
merged 1 commit into from
Jun 14, 2023
Merged

chore(ssa refactor): print ssa passes on flag only #1685

merged 1 commit into from
Jun 14, 2023

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

SSA passes always show, which chokes the CI test logs

Summary*

SSA passes now only show when using the existing --show-ssa flag.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@joss-aztec joss-aztec mentioned this pull request Jun 14, 2023
Closed
@joss-aztec joss-aztec added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit dbd6db8 Jun 14, 2023
@joss-aztec joss-aztec deleted the joss/show-ssa-flag branch June 14, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joss-aztec @vezenovm