Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Add code to handle array equality #1635

Closed
wants to merge 39 commits into from
Closed

chore(ssa refactor): Add code to handle array equality #1635

wants to merge 39 commits into from

Commits on Jun 10, 2023

  1. separate brillig only logic from logic that combines both brillig and… 

    … ssa
    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0c94eee View commit details
    Browse the repository at this point in the history

  2. move operations related to brillig-ssa conversion to brillig_gen

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9b12a6e View commit details
    Browse the repository at this point in the history

  3. intermediate step -- make build work by leaking the abstraction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    1efaa84 View commit details
    Browse the repository at this point in the history

  4. refactor return instruction -- all of the implementation details abou… 

    …t brillig are no longer in brillig_gen
    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4dad872 View commit details
    Browse the repository at this point in the history

  5. fix clippy

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2ea78a7 View commit details
    Browse the repository at this point in the history

  6. add TODO

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2ea7ca1 View commit details
    Browse the repository at this point in the history

  7. move convert_integer_mod into BrilligIr

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    8cf6737 View commit details
    Browse the repository at this point in the history

  8. encapsulate modulo operation in brillig_gen

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    853baf2 View commit details
    Browse the repository at this point in the history

  9. process binary instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    d57784b View commit details
    Browse the repository at this point in the history

  10. refactor const instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f923c41 View commit details
    Browse the repository at this point in the history

  11. make code surrounding jumps satisfy the abstraction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    170bcd5 View commit details
    Browse the repository at this point in the history

  12. move not instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    4021e7f View commit details
    Browse the repository at this point in the history

  13. add foreign call instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f3a7e82 View commit details
    Browse the repository at this point in the history

  14. move load and store instructions to brillig_ir

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    47a56a3 View commit details
    Browse the repository at this point in the history

  15. move truncate instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    bde51e3 View commit details
    Browse the repository at this point in the history

  16. move mov, stop and allocate_array methods

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    dc47158 View commit details
    Browse the repository at this point in the history

  17. fix clippy

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    58038a7 View commit details
    Browse the repository at this point in the history

  18. remove push_code method in brillig_gen

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    df8bc75 View commit details
    Browse the repository at this point in the history

  19. move jump and jmpif instructions to brillig_ir

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    aa577d9 View commit details
    Browse the repository at this point in the history

  20. clean up terminator instruction

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    7770c79 View commit details
    Browse the repository at this point in the history

  21. remove allow(deprecated) lint

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    060ce73 View commit details
    Browse the repository at this point in the history

  22. refactor document for link and link_with

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2f4118f View commit details
    Browse the repository at this point in the history

  23. use .into so we can get rid of Value import

    @kevaundray
    kevaundray committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5254d3d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. add docs

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    9b6886f View commit details
    Browse the repository at this point in the history

  2. make code a bit clearer

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    86b8360 View commit details
    Browse the repository at this point in the history

  3. add array_eq example

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    622c987 View commit details
    Browse the repository at this point in the history

  4. memory now returns an allocation struct

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    fecdfee View commit details
    Browse the repository at this point in the history

  5. Modify allocate array to expand memory on stores

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    82b7b70 View commit details
    Browse the repository at this point in the history

  6. add code to handle array_eq

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    236d2e0 View commit details
    Browse the repository at this point in the history

  7. add note on potential bug

    @kevaundray
    kevaundray committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e9bd25c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Merge branch 'kw/brillig-main' into arv/brillig-array-eq

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    718d682 View commit details
    Browse the repository at this point in the history

  2. feat: implemented array equality

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d7fd8b4 View commit details
    Browse the repository at this point in the history

  3. fix: remove extraneous array access

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ec2bf1a View commit details
    Browse the repository at this point in the history

  4. docs: added comments

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4d0c132 View commit details
    Browse the repository at this point in the history

  5. refactor: binary ops for arrays and reduce op

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    cb3f03c View commit details
    Browse the repository at this point in the history

  6. docs: rewrite some comments

    @sirasistant
    sirasistant committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ac9dec6 View commit details
    Browse the repository at this point in the history

  7. add bytecode for array_eq

    @kevaundray
    kevaundray committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a85cab0 View commit details
    Browse the repository at this point in the history

  8. make code simpler by jumping to the start if the condition is true

    @kevaundray
    kevaundray committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    fbb0035 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. style: fix clippy

    @sirasistant
    sirasistant committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8e0fdee View commit details
    Browse the repository at this point in the history