Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssa): add block opcode #1291

Merged
merged 2 commits into from
May 4, 2023
Merged

fix(ssa): add block opcode #1291

merged 2 commits into from
May 4, 2023

Conversation

guipublic
Copy link
Contributor

@guipublic guipublic commented May 4, 2023

Related issue(s)

Resolves #1283

Description

Summary of changes

Adds the BLOCK opcode for supporting dynamic memory.
In fact this opcode was created specifically for this problem. However I forgot to use it when I enabled dynamic memory as too much time has passed until the linear eval is not 0 issue was finally fixed!

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

BEGIN_COMMIT_OVERRIDE
feat(ssa): add block opcode (#1291)
END_COMMIT_OVERRIDE

kevaundray
kevaundray previously approved these changes May 4, 2023
@kevaundray kevaundray changed the title fix(1283): add block opcode fix(ssa): add block opcode May 4, 2023
@kevaundray kevaundray added this pull request to the merge queue May 4, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request May 4, 2023
@kevaundray
Copy link
Contributor

PR looks good -- pulled it from the queue to see if we can add a regression test for this. Ideally this would have been caught by the dynamic_array example

@guipublic
Copy link
Contributor Author

I added a regression test

@kevaundray kevaundray enabled auto-merge May 4, 2023 15:43
@kevaundray kevaundray added this pull request to the merge queue May 4, 2023
Merged via the queue into master with commit 951ad71 May 4, 2023
@kevaundray kevaundray deleted the gd/issue_1283 branch May 4, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: cannot solve opcode: expression has too many unknowns
2 participants