Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use RAM/ROM opcode when supported by the backend #1282

Merged
merged 57 commits into from
Jun 14, 2023

Conversation

guipublic
Copy link
Contributor

Related issue(s)

Resolves #

Description

Summary of changes

This PR generates RAM and ROM opcodes if they are supported by the backend.
This will allow aztec backend to use UP loopk-ups for memory operations

Test additions / changes

We need a backend which support the opcodes.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

@guipublic
Copy link
Contributor Author

guipublic commented May 25, 2023

I don't understand why we are removing functionalities, using the proper opcode sooner is better than using a wrong one and changing it after. We want to reach an impossible target which is the backend-agnostic acir, and for what benefit?

@guipublic
Copy link
Contributor Author

I removed the usage of is_opcode_supported() and hardcoded the barretenberg support of the memory gates instead.
Happy to revert this if we decide to!

@kevaundray
Copy link
Contributor

MacOS is taking nearly 5 hours to complete -- I'm going to redo the workflow

@Savio-Sou
Copy link
Collaborator

Blocked by noir-lang/Planning#21.

@Savio-Sou Savio-Sou requested a review from kevaundray June 2, 2023 07:55
@Savio-Sou
Copy link
Collaborator

Good to merge?

flake.nix Outdated Show resolved Hide resolved
@kevaundray kevaundray added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit 242f07b Jun 14, 2023
@kevaundray kevaundray deleted the gd/dynamic_array9 branch June 14, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants