fix: add more readable error for missing argument in toml #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves the second part of #969
Description
Summary of changes
Previously we'd iterate over the fields in
Prover.toml
, assume there's a matching entry in the ABI and then decode the data. This throws an unhelpful panic ifProver.toml
contains an entry which doesn't exist in the ABI when looking up its type.I've updated this loop to instead work over the expected ABI fields, check if an entry exists in
Prover.toml
and if not we raise an error saying that the argument with a certain name hasn't been found. As part of this we now pass the argument name intotry_from_toml
so that we can throw a meaningful error for struct fields.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context