Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nargo contract command #945

Closed
TomAFrench opened this issue Mar 3, 2023 · 2 comments · Fixed by #959
Closed

Rename nargo contract command #945

TomAFrench opened this issue Mar 3, 2023 · 2 comments · Fixed by #959
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

As we add Noir contracts, there's going to become confusion around the nargo contract command. Does it create a solidity verifier contract or does it do something else related to noir contracts?

We should then update the name to avoid any confusion. One option is:

nargo generate-verifier --solidity perhaps? We could then extend it to other languages, etc.

Originally posted by @TomAFrench in #944 (comment)

@TomAFrench TomAFrench added the enhancement New feature or request label Mar 3, 2023
@kevaundray
Copy link
Contributor

Think we want to get this in quite quickly as its an annoying breaking change that is in a lot of places.

$ nargo generate-verifier --solidity

@noir-lang/tooling what do you think about the above change? Any suggestions for something better?

@joss-aztec
Copy link
Contributor

I like your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants