fix: correct type checking to handle false
bools
#893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #889
Description
Summary of changes
FieldElement.num_bits()
returns 0 for `FieldElement::zero() so the current check for satisfying the AbiType fails. I've relaxed the check to accept 0 or 1 bits to address this.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context