Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid testing equality between unit values in acir_gen test #849

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix: avoid testing equality between unit values in acir_gen test #849

merged 3 commits into from
Feb 15, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #

Description

Summary of changes

a_val.sort() returns () so this equality will always succeed. We now sort prior to passing these arrays into the assert_eq.

Dependency additions / changes

N/A

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench
fix: avoid testing equality between unit values
a5a66c1 
`a_val.sort()` returns `()` so this equality will always succeed
jfecher
jfecher approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench added this pull request to the merge queue Feb 15, 2023
Merged via the queue into master with commit c2b7230 Feb 15, 2023
@TomAFrench TomAFrench deleted the TomAFrench-patch-1 branch February 15, 2023 16:34
@kevaundray kevaundray mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated left review comments

@jfecher jfecher jfecher approved these changes

@guipublic guipublic Awaiting requested review from guipublic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAFrench @phated @jfecher