Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the as_field and from_field built-ins with the From<Field> and Into<Field> traits #6838

Closed
asterite opened this issue Dec 17, 2024 · 0 comments · Fixed by #6845
Closed

Replace the as_field and from_field built-ins with the From<Field> and Into<Field> traits #6838

asterite opened this issue Dec 17, 2024 · 0 comments · Fixed by #6845
Assignees
@asterite
Labels
enhancement New feature or request

Comments

@asterite
Copy link
Collaborator

Problem

A comment by Jake:

@asterite only the various integer types. It's an old builtin from before we had traits. We really should remove it and replace it with From<Field> and Into<Field>

Happy Case

The built-ins and corresponding intrinsics are replaced and removed.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@asterite asterite added the enhancement New feature or request label Dec 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 17, 2024
@asterite asterite mentioned this issue Dec 17, 2024
Merged
5 tasks
@TomAFrench TomAFrench moved this from 📋 Backlog to 🏗 In progress in Noir Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

Labels
enhancement New feature or request
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove the as_field and from_field built-ins noir-lang/noir
1 participant
@asterite