-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add machine readable test reports #6733
Comments
Note that we'd want to have some mechanism to flag when ignored tests should be reactivated again. |
I'm thinking how to do this. For each repo, here's what can happen:
So, for each repo, we want to have a file that tells it's status, one of:
So maybe it can be a yaml file. # All good
compiles: true
known_failures: [] # Some tests fail
compiles: true
known_failures:
- test_one
- test_two # Does not compile
compiles: false
# this list could be non-empty and it's just ignored, but it's useful to keep around
# when the project starts compiling again
known_failures: [] But then this logic seems a bit too complex to have in a |
I don't think that it's necessary to add this into nargo (and would prefer we didn't). I think some use of jq would avoid this. |
noir/.github/workflows/test-js-packages.yml Line 537 in bc03152
Something like this to get a JSON object which contains tests along with their success statuses which we then compare against the yaml/JSON file. |
We currently run tests from external repositories only if the
run-external-checks
flag is set manually. This means that we can have regressions sneak in through PRs where this flag has not been set however we also cannot run it by default as any test failures due to breaking changes will cause our CI to fail until the external repository has been updated.One solution to this would be for us to add a machine-readable report option to
nargo test
. This would allow us to filter out any expected failures to be ignored when when considering whether to fail CI or not.See https://nexte.st/docs/machine-readable/libtest-json/ for inspiration.
The text was updated successfully, but these errors were encountered: