Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove catch-all case for pedersen hash blackbox function #3370

Closed
kevaundray opened this issue Oct 30, 2023 · 0 comments · Fixed by #3744
Closed

Remove catch-all case for pedersen hash blackbox function #3370

kevaundray opened this issue Oct 30, 2023 · 0 comments · Fixed by #3744
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

In order to migrate to the new pedersen hash function, we added in this TODO which specifies that pedersen is unconditionally supported. This should be removed.

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 30, 2023
@hayleykwan hayleykwan mentioned this issue Dec 9, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2023
@hayleykwan
chore: remove special casing for pedersen_hash black box function (#…
1c66b24 
…3744)

# Description

## Problem\*

Resolves #3370 

## Summary\*

This PR removes the special case which says all backends support the
pedersen hash black box function.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove special casing for pedersen_hash black box function hayleykwan/noir
1 participant
@kevaundray