Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in poseidon hash in Noir documentation #3337

Closed
TAdev0 opened this issue Oct 29, 2023 · 3 comments · Fixed by #3608
Closed

Inconsistency in poseidon hash in Noir documentation #3337

TAdev0 opened this issue Oct 29, 2023 · 3 comments · Fixed by #3608
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@TAdev0
Copy link
Contributor

TAdev0 commented Oct 29, 2023

Aim

While starting to learn how to use Noir language and Nargo, i noticed there is an inconsistency in the "Hash method" section of Noir standard library documentation :

example:

fn main()
{
  let hash1 = std::hash::poseidon::bn254::hash_2([1, 2]);
  assert(hash1 == 0x115cc0f5e7d690413df64c6b9662e9cf2a3617f2743245519e19607a4417189a);
}

Expected Behavior

This section should be :

example:

fn main()
{
  let hash2 = std::hash::poseidon::bn254::hash_2([1, 2]);
  assert(hash2 == 0x115cc0f5e7d690413df64c6b9662e9cf2a3617f2743245519e19607a4417189a);
}

Would you like to submit a PR for this Issue?

Yes

@TAdev0 TAdev0 added the bug Something isn't working label Oct 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 29, 2023
@kevaundray kevaundray added documentation Improvements or additions to documentation P-LOW labels Oct 29, 2023
@TAdev0
Copy link
Contributor Author

TAdev0 commented Nov 28, 2023

@kevaundray should i propose a PR for this ? i'm willing to contribute to Noir ecosystem but i didn't get any answer for a month. Thank you!

@kevaundray
Copy link
Contributor

@kevaundray should i propose a PR for this ? i'm willing to contribute to Noir ecosystem but i didn't get any answer for a month. Thank you!

Hey sorry for not being explicit. Please submit a PR!

@TAdev0
Copy link
Contributor Author

TAdev0 commented Nov 28, 2023

@kevaundray thanks for the quick answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants