You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this also means that devs need to import and manage versioning for noir_js, acvm_js, and optionally noir_wasm, reducing the usefulness of noir_js in the first place
would be worth to try making them only one, and abstracted within the noir_js main export (class, object, whatever it is). This avoids passing the circuit twice, as it can be stored within the Noir class. Suggestion:
constnoir=newNoir(circuit)// here goes the circuit, is stored in the classconstwitness=awaitnoir.generateWitness(input)// just need to pass the input
The text was updated successfully, but these errors were encountered:
Didn't yet check acvm_js library but it seems to be an amazing lib we could just use in this method instead of the low-brain Map.set we have there 😄 Actually the reason I didn't try it in noir-starter is because it will be refactored pretty soon with noir_js anyway
Part of the first
noir_js
devex review.With the current versions, we need to call two methods in order to generate a witness:
this also means that devs need to import and manage versioning for
noir_js
,acvm_js
, and optionallynoir_wasm
, reducing the usefulness ofnoir_js
in the first placewould be worth to try making them only one, and abstracted within the
noir_js
main export (class, object, whatever it is). This avoids passing the circuit twice, as it can be stored within the Noir class. Suggestion:The text was updated successfully, but these errors were encountered: