Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages from Rust in noirc_abi_wasm #2806

Closed
TomAFrench opened this issue Sep 25, 2023 · 1 comment
Closed

Improve error messages from Rust in noirc_abi_wasm #2806

TomAFrench opened this issue Sep 25, 2023 · 1 comment
Assignees
@TomAFrench
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

Currently we don't provide good error messages for ABI encoding from noirc_abi_wasm due to the fact we just panic.

Happy Case

We should provide feedback for how the user may have provided an invalid input. We can use acvm_js as a example for this.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@TomAFrench TomAFrench added the enhancement New feature or request label Sep 25, 2023
@TomAFrench TomAFrench self-assigned this Sep 25, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 25, 2023
@TomAFrench
Copy link
Member Author

Closed by #2817

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomAFrench