Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message for a contract package with no contracts #2762

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR has a quick fix for the panic that Lisa was experiencing where Nargo cannot find any contracts within a contract package.

Rather than panicking when we assert that we have a single contract, we return an error message similar to that for when a binary crate has no main function.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit 9701a0c Sep 20, 2023
16 checks passed
@TomAFrench TomAFrench deleted the tf/better-errors-for-zero-contracts branch September 20, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants