Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use high limb in scalar multiplication #2619

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Related to #2588

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title fix: Use high limb in scalar multiplication fix: Use high limb in scalar multiplication [DO NOT MERGE] Sep 8, 2023
@kevaundray
Copy link
Contributor Author

This is reliant on acvm 0.26.1 -- it seems that this was not published when we released acvm 0.26.1 -- @jonybur any insights?

@kevaundray kevaundray changed the title fix: Use high limb in scalar multiplication [DO NOT MERGE] fix: Use high limb in scalar multiplication Sep 13, 2023
@kevaundray kevaundray added this pull request to the merge queue Sep 13, 2023
Merged via the queue into master with commit 9014b8a Sep 13, 2023
17 checks passed
@kevaundray kevaundray deleted the kw/fix-scalar-mul-impl-high-limb branch September 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants