Optimize update_acir

[Ethan-000]

Problem

currently update_acir is taking a lot of times in some programs eg. eddsa and sha2_blocks execution

eddsa:

sha2_blocks:

did some changes it seems these can be avoided

Happy Case

optimize this to

eddsa:

sha2_blocks:

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response

[Ethan-000]

ping @kevaundray for visibility

[kevaundray]

Nice! Can you explain the changes you made and quantify the difference in terms of percentage improvements?

[Ethan-000]

eddsa execution after optimization:

eddsa execution before optimization:

sha2block didn't change much based on criterion results it seems

after optmization

before optimization

[Ethan-000]

I think the way the code was written. the compiler was calling an internal method that allocates memory by collecting it into a vector, which can be avoided.

[kevaundray]

eddsa execution after optimization:

eddsa execution before optimization: sha2block didn't change much based on criterion results it seems

after optmization

before optimization

Ah thanks for the numbers -- yeah this might become more pronounced the larger the program