Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: proving with bb.js and noir #2252

Closed
Tracked by #2251
jonybur opened this issue Aug 10, 2023 · 3 comments
Closed
Tracked by #2251

Testing: proving with bb.js and noir #2252

jonybur opened this issue Aug 10, 2023 · 3 comments
Assignees

Comments

@jonybur
Copy link
Contributor

jonybur commented Aug 10, 2023

Description:
Ensure that the provided ACIR and the solved witness are provable by bb.js. In the case of bb.js, this should be inclusive of both browser and node versions.

Acceptance Criteria:

  • bb.js (browser & node) should correctly generate proof based on a provided ACIR and witness.
  • a GitHub workflow should be added that verifies the output of both modules and checks that it matches.
@jonybur jonybur added this to Noir Aug 10, 2023
@jonybur jonybur converted this from a draft issue Aug 10, 2023
@jonybur jonybur self-assigned this Aug 10, 2023
@Savio-Sou
Copy link
Collaborator

bb.js (browser & node) and noir should both correctly generate proof...

What do you mean by noir should generate a proof?

@Savio-Sou
Copy link
Collaborator

Link to current Noir tests in the barretenberg repo in case if it's helpful: https://github.com/AztecProtocol/barretenberg/blob/master/acir_tests/run_acir_tests.sh

@Savio-Sou
Copy link
Collaborator

Works superseded by AztecProtocol/aztec-packages#1855.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants