Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract should be a CrateType instead of a flag and specified in Nargo.toml #2075

Closed
Tracked by #2162
phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2204
Closed
Tracked by #2162

Contract should be a CrateType instead of a flag and specified in Nargo.toml #2075

phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2204
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 27, 2023

Problem

Currently, contracts are only supported by some nargo commands and they require a special flag. This seems counter-intuitive because a contract package is always a contract package. This should be configured inside a Nargo.toml file instead and supported across all commands.

Happy Case

A crate can be configured as a "contract crate type" and all commands will use the logic to compile contracts.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the enhancement New feature or request label Jul 27, 2023
@phated phated self-assigned this Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 27, 2023
@phated
Copy link
Contributor Author

phated commented Jul 27, 2023

Related to #1970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants